Re: [RFC V2 5/6] blk-ioprio: make ioprio pluggable and modular
From: Bart Van Assche <bvanassche@acm.org>
Date: 2022-02-15 21:27:01
Also in:
lkml
On 2/15/22 04:37, Wang Jianchao (Kuaishou) wrote:
quoted hunk ↗ jump to hunk
diff --git a/block/Makefile b/block/Makefile index f38eaa612929..f6a3995af285 100644 --- a/block/Makefile +++ b/block/Makefile@@ -17,7 +17,8 @@ obj-$(CONFIG_BLK_DEV_BSGLIB) += bsg-lib.o obj-$(CONFIG_BLK_CGROUP) += blk-cgroup.o obj-$(CONFIG_BLK_CGROUP_RWSTAT) += blk-cgroup-rwstat.o obj-$(CONFIG_BLK_DEV_THROTTLING) += blk-throttle.o -obj-$(CONFIG_BLK_CGROUP_IOPRIO) += blk-ioprio.o +io-prio-y := blk-ioprio.o +obj-$(CONFIG_BLK_CGROUP_IOPRIO) += io-prio.o obj-$(CONFIG_BLK_CGROUP_IOLATENCY) += blk-iolatency.o obj-$(CONFIG_BLK_CGROUP_IOCOST) += blk-iocost.o obj-$(CONFIG_MQ_IOSCHED_DEADLINE) += mq-deadline.o
Is the above change really necessary?
+static int blk_ioprio_init(struct request_queue *q);
static struct rq_qos_ops blkcg_ioprio_ops = {Please insert a blank line between a function declaration and a structure definition. Thanks, Bart.