[RFC PATCH 3/7] block: allow to bypass bio check before submitting bio
From: Ming Lei <hidden>
Date: 2022-01-11 11:56:28
Subsystem:
block layer, the rest · Maintainers:
Jens Axboe, Linus Torvalds
We have several cases in which bio is re-submitted to same queue, so checking bio isn't needed, so add helper for such propose. Signed-off-by: Ming Lei <redacted> --- block/blk-core.c | 10 +++++----- include/linux/blkdev.h | 7 ++++++- 2 files changed, 11 insertions(+), 6 deletions(-)
diff --git a/block/blk-core.c b/block/blk-core.c
index 471ffc834e3f..1e6ebc16b889 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c@@ -818,7 +818,7 @@ static void __submit_bio(struct bio *bio) * bio_list_on_stack[1] contains bios that were submitted before the current * ->submit_bio_bio, but that haven't been processed yet. */ -static void __submit_bio_noacct(struct bio *bio) +static void __submit_bio_noacct_generic(struct bio *bio) { struct bio_list bio_list_on_stack[2];
@@ -884,9 +884,9 @@ static void __submit_bio_noacct_mq(struct bio *bio) * systems and other upper level users of the block layer should use * submit_bio() instead. */ -void submit_bio_noacct(struct bio *bio) +void __submit_bio_noacct(struct bio *bio, bool check) { - if (unlikely(!submit_bio_checks(bio))) + if (unlikely(check && !submit_bio_checks(bio))) return; /*
@@ -900,9 +900,9 @@ void submit_bio_noacct(struct bio *bio) else if (!bio->bi_bdev->bd_disk->fops->submit_bio) __submit_bio_noacct_mq(bio); else - __submit_bio_noacct(bio); + __submit_bio_noacct_generic(bio); } -EXPORT_SYMBOL(submit_bio_noacct); +EXPORT_SYMBOL(__submit_bio_noacct); /** * submit_bio - submit a bio to the block device layer for I/O
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 22746b2d6825..e02a73d7c277 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h@@ -599,7 +599,12 @@ static inline unsigned int blk_queue_depth(struct request_queue *q) extern int blk_register_queue(struct gendisk *disk); extern void blk_unregister_queue(struct gendisk *disk); -void submit_bio_noacct(struct bio *bio); +void __submit_bio_noacct(struct bio *bio, bool check); + +static inline void submit_bio_noacct(struct bio *bio) +{ + __submit_bio_noacct(bio, true); +} extern int blk_lld_busy(struct request_queue *q); extern void blk_queue_split(struct bio **);
--
2.31.1