Re: [PATCH 1/2] mm: move filemap_range_needs_writeback() into header

On 12/3/21 11:14 AM, Matthew Wilcox wrote:

On Fri, Dec 03, 2021 at 11:01:14AM -0700, Jens Axboe wrote:

quoted

On 12/3/21 10:57 AM, Jens Axboe wrote:

quoted

quoted

I'm happy with this, if you just move it to pagemap.h

OK, I'll try it out.

Wasn't too bad at all, actually just highlighted that I missed removing
the previous declaration of filemap_range_needs_writeback() in fs.h
I'll do a full compile and test, but this seems sane.

commit 63c6b3846b77041d239d5b5b5a907b5c82a21c4c
Author: Jens Axboe [off-list ref]
Date:   Thu Oct 28 08:47:05 2021 -0600

    mm: move filemap_range_needs_writeback() into header
    
    No functional changes in this patch, just in preparation for efficiently
    calling this light function from the block O_DIRECT handling.
    
    Signed-off-by: Jens Axboe [off-list ref]

Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>

Great, thanks for the review Willy!

-- 
Jens Axboe