Re: [PATCH v4 01/23] lib/scatterlist: cleanup macros into static inline functions

On 2021-12-21 2:00 a.m., Christoph Hellwig wrote:

On Wed, Nov 17, 2021 at 02:53:48PM -0700, Logan Gunthorpe wrote:

quoted

Convert the sg_is_chain(), sg_is_last() and sg_chain_ptr() macros
into static inline functions. There's no reason for these to be macros
and static inline are generally preferred these days.

Also introduce the SG_PAGE_LINK_MASK define so the P2PDMA work, which is
adding another bit to this mask, can do so more easily.

Suggested-by: Jason Gunthorpe <jgg@nvidia.com>
Signed-off-by: Logan Gunthorpe <logang@deltatee.com>

Looks fine:

Reviewed-by: Christoph Hellwig <hch@lst.de>

scatterlist.h doesn't have a real maintainer, do you want me to pick
this up through the DMA tree?

Sure, that would be great!

Thanks,

Logan