Re: [PATCH 4/7] block: remove the NULL ioc check in put_io_context
From: Jan Kara <jack@suse.cz>
Date: 2021-11-30 15:03:47
On Tue 30-11-21 13:46:33, Christoph Hellwig wrote:
No caller passes in a NULL pointer, so remove the check. Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks good. Feel free to add: Reviewed-by: Jan Kara <jack@suse.cz> Honza
quoted hunk ↗ jump to hunk
--- block/blk-ioc.c | 3 --- 1 file changed, 3 deletions(-)diff --git a/block/blk-ioc.c b/block/blk-ioc.c index 0380e33930e31..04f3d2b0ca7db 100644 --- a/block/blk-ioc.c +++ b/block/blk-ioc.c@@ -155,9 +155,6 @@ void put_io_context(struct io_context *ioc) unsigned long flags; bool free_ioc = false; - if (ioc == NULL) - return; - BUG_ON(atomic_long_read(&ioc->refcount) <= 0); /*-- 2.30.2
-- Jan Kara [off-list ref] SUSE Labs, CR