Re: [PATCH 0/2] block: Fix stale page cache of discard or zero out ioctl

On Nov 09, 2021 / 12:59, Jan Kara wrote:

On Tue 09-11-21 19:07:26, Ming Lei wrote:

quoted

On Tue, Nov 09, 2021 at 07:47:21PM +0900, Shin'ichiro Kawasaki wrote:

quoted

When BLKDISCARD or BLKZEROOUT ioctl race with data read, stale page cache is
left. This patch series have two fox patches for the stale page cache. Same
fix approach was used as blkdev_fallocate() [1].

[1] https://marc.info/?l=linux-block&m=163236463716836

Shin'ichiro Kawasaki (2):
  block: Hold invalidate_lock in BLKDISCARD ioctl
  block: Hold invalidate_lock in BLKZEROOUT ioctl

 block/ioctl.c | 24 ++++++++++++++++++------
 1 file changed, 18 insertions(+), 6 deletions(-)

Yeah, the discard ioctl needs such fixes too, seems it isn't triggered
in the test disk of my test VM when running block/009.

BTW, BLKRESETZONE may need the fix too.

Yeah, it seems like that.

Thanks for the comments. I'll work on BLKRESETZONE also.

-- 
Best Regards,
Shin'ichiro Kawasaki