Thread (1 message) 1 message, 1 author, 2021-11-08
DORMANTno replies

[PATCH v2] block: Remove the redundant empty list check in blk_flush_plug

From: Pankaj Raghav <hidden>
Date: 2021-11-08 15:13:07
Subsystem: block layer, the rest · Maintainers: Jens Axboe, Linus Torvalds

The callee: blk_mq_flush_plug_list already has an empty list check for
plug->mq_list. Remove the check for empty list from the
caller:blk_flush_plug.

Signed-off-by: Pankaj Raghav <redacted>
---
 block/blk-core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/blk-core.c b/block/blk-core.c
index b043de2baaac..a309e7cca218 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -1588,8 +1588,8 @@ void blk_flush_plug(struct blk_plug *plug, bool from_schedule)
 {
 	if (!list_empty(&plug->cb_list))
 		flush_plug_callbacks(plug, from_schedule);
-	if (!rq_list_empty(plug->mq_list))
-		blk_mq_flush_plug_list(plug, from_schedule);
+
+	blk_mq_flush_plug_list(plug, from_schedule);
 	/*
 	 * Unconditionally flush out cached requests, even if the unplug
 	 * event came from schedule. Since we know hold references to the
-- 
2.25.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help