Re: [PATCH v2 3/3] blk-crypto: show crypto capabilities in sysfs

From
Eric Biggers <ebiggers@kernel.org>
Date
2021-11-30 07:40:23
Also in
linux-api, linux-mmc, linux-scsi, lkml
Reply to
Hannes Reinecke, 2021-11-30
On Tue, Nov 30, 2021 at 07:49:54AM +0100, Hannes Reinecke wrote:
quoted
   - "modes" is a sub-subdirectory, since there may be multiple supported
     crypto modes, and sysfs is supposed to have one value per file.
Why do you have a sub-directory here?
From what I can see, that subdirectory just contains the supported modes, so
wouldn't it be easier to create individual files like 'mode_<modename>'
instead of a subdirectory?
It is a group of attributes, so it makes sense to group them together rather
than put them all in the parent directory alongside other attributes.  It also
allows the use of proper names like "AES-256-XTS" rather than weird names like
"mode_AES-256-XTS" or "mode_aes_256_xts".

- Eric
Thread (13 messages) 13 messages, 3 authors, last reply 2021-12-01
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help