On Wed, Nov 24, 2021 at 12:53 AM Srinivas Pandruvada
[off-list ref] wrote:

On Tue, 2021-11-23 at 14:19 +0100, Rafael J. Wysocki wrote:

quoted

On Wed, Aug 18, 2021 at 8:08 AM Kees Cook [off-list ref]
wrote:

quoted

In preparation for FORTIFY_SOURCE performing compile-time and run-
time
field bounds checking for memcpy(), avoid intentionally writing
across
neighboring fields.

Use struct_group() in struct art around members weight, and ac[0-
9]_max,
so they can be referenced together. This will allow memcpy() and
sizeof()
to more easily reason about sizes, improve readability, and avoid
future
warnings about writing beyond the end of weight.

"pahole" shows no size nor member offset changes to struct art.
"objdump -d" shows no meaningful object code changes (i.e. only
source
line number induced differences).

Cc: Zhang Rui <rui.zhang@intel.com>
Cc: Daniel Lezcano <redacted>
Cc: Amit Kucheria <amitk@kernel.org>
Cc: linux-pm@vger.kernel.org
Signed-off-by: Kees Cook <redacted>

Rui, Srinivas, any comments here?

Looks good.
Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>

Applied as 5.17 material, thank you!