Thread (21 messages) 21 messages, 7 authors, 2021-10-29

Re: [PATCH 0/3] implement direct IO with integrity

From: Christoph Hellwig <hch@lst.de>
Date: 2021-10-28 15:18:55

On Thu, Oct 28, 2021 at 09:13:07AM -0600, Jens Axboe wrote:
A couple of suggestions on this:

1) Don't think we need an IOSQE flag, those are mostly reserved for
   modifiers that apply to (mostly) all kinds of requests
2) I think this would be cleaner as a separate command, rather than
   need odd adjustments and iov assumptions. That also gets it out
   of the fast path.

I'd add IORING_OP_READV_PI and IORING_OP_WRITEV_PI for this, I think
you'd end up with a much cleaner implementation that way.
Agreed.  I also wonder if we could do saner paramter passing.
E.g. pass a separate pointer to the PI data if we find space for
that somewhere in the SQE.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help