Thread (37 messages) 37 messages, 4 authors, 2021-10-19

Re: [PATCH 01/14] block: inline fast path of driver tag allocation

From: Jens Axboe <axboe@kernel.dk>
Date: 2021-10-18 14:38:32

On 10/18/21 2:42 AM, Christoph Hellwig wrote:
On Sat, Oct 16, 2021 at 07:37:35PM -0600, Jens Axboe wrote:
quoted
If we don't use an IO scheduler or have shared tags, then we don't need
to call into this external function at all. This saves ~2% for such
a setup.
This looks correct, although the call chain gets a little confusing
now.  How much difference is this over basically inlining the
whole old blk_mq_get_driver_tag?
It just condenses the fast path into the checks upfront. I can run the
numbers, but it'll be extra work.

-- 
Jens Axboe
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help