Re: [PATCH v2] fs: replace the ki_complete two integer arguments with a single argument
From: Jens Axboe <axboe@kernel.dk>
Date: 2021-10-21 20:41:26
Also in:
linux-fsdevel, linux-usb
Subsystem:
aio, filesystems (vfs and infrastructure), the rest · Maintainers:
Benjamin LaHaise, Alexander Viro, Christian Brauner, Linus Torvalds
Possibly related (same subject, not in this thread)
- 2021-10-22 · Re: [PATCH v2] fs: replace the ki_complete two integer arguments with a single argument · Jens Axboe <axboe@kernel.dk>
- 2021-10-22 · Re: [PATCH v2] fs: replace the ki_complete two integer arguments with a single argument · Jens Axboe <axboe@kernel.dk>
- 2021-10-22 · Re: [PATCH v2] fs: replace the ki_complete two integer arguments with a single argument · Jens Axboe <axboe@kernel.dk>
- 2021-10-21 · Re: [PATCH v2] fs: replace the ki_complete two integer arguments with a single argument · Jeff Moyer <hidden>
- 2021-10-21 · Re: [PATCH v2] fs: replace the ki_complete two integer arguments with a single argument · Jeff Moyer <hidden>
On 10/21/21 12:05 PM, Jeff Moyer wrote:
quoted
quoted
I'll follow up if there are issues.s390 (big endian, 64 bit) is failing libaio test 21: # harness/cases/21.p Expected -EAGAIN, got 4294967285 If I print out both res and res2 using %lx, you'll see what happened: Expected -EAGAIN, got fffffff5,ffffffff The sign extension is being split up.
Funky, does it work if you apply this on top?
diff --git a/fs/aio.c b/fs/aio.c
index 3674abc43788..c56437908339 100644
--- a/fs/aio.c
+++ b/fs/aio.c@@ -1442,8 +1442,8 @@ static void aio_complete_rw(struct kiocb *kiocb, u64 res) * 32-bits of value at most for either value, bundle these up and * pass them in one u64 value. */ - iocb->ki_res.res = lower_32_bits(res); - iocb->ki_res.res2 = upper_32_bits(res); + iocb->ki_res.res = (long) (res & 0xffffffff); + iocb->ki_res.res2 = (long) (res >> 32); iocb_put(iocb); }
--
Jens Axboe