Re: [PATCH] fs: kill unused ret2 argument from iocb->ki_complete()

From
Christoph Hellwig <hch@infradead.org>
Date
2021-10-20 17:30:27
Also in
linux-fsdevel
Reply to
Jens Axboe, 2021-10-20
On Wed, Oct 20, 2021 at 10:49:07AM -0600, Jens Axboe wrote:
It's not used for anything, and we're wasting time passing in zeroes
where we could just ignore it instead. Update all ki_complete users in
the kernel to drop that last argument.

The exception is the USB gadget code, which passes in non-zero. But
since nobody every looks at ret2, it's still pointless.
Yes, the USB gadget passes non-zero, and aio passes that on to
userspace.  So this is an ABI change.  Does it actually matter?
I don't know, but you could CC the relevant maintainers and list
to try to figure that out.
Thread (9 messages) 9 messages, 4 authors, last reply 2021-10-23
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help