Re: [PATCH 14/16] block: switch polling to be bio based

From
Christoph Hellwig <hch@lst.de>
Date
2021-10-15 13:24:55
Also in
linux-fsdevel, linux-nvme
Reply to
Pankaj Raghav, 2021-10-15
On Fri, Oct 15, 2021 at 10:30:26AM +0200, Pankaj Raghav wrote:
quoted
@@ -568,7 +569,8 @@ blk_status_t errno_to_blk_status(int errno);
 #define BLK_POLL_ONESHOT		(1 << 0)
 /* do not sleep to wait for the expected completion time */
 #define BLK_POLL_NOSLEEP		(1 << 1)
Minor comment: Could we also have a flag #define BLK_POLL_SPIN 0?
It can improve the readability from the caller side instead of having
just a 0 to indicate spinning.
The above are flags, so adding a define for a value is a bit counter
productive.
Thread (35 messages) 35 messages, 7 authors, last reply 2021-11-03
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help