Thread (13 messages) 13 messages, 3 authors, 2021-10-22

Re: [PATCH V2 0/4] zram: fix two races and one zram leak

From: Luis Chamberlain <mcgrof@kernel.org>
Date: 2021-10-21 17:39:52
Also in: lkml

On Wed, Oct 20, 2021 at 02:40:05PM -0700, Minchan Kim wrote:
On Wed, Oct 20, 2021 at 09:55:44AM +0800, Ming Lei wrote:
quoted
Hello,

Fixes three issues reported by Luis Chamberlain with one simpler approach:

- race between between zram_reset_device() and disksize_store() (1/4)

- zram leak during unloading module, which is one race between resetting
and removing device (2/4)

- race between zram_remove and disksize_store (3/4)

Also replace replace fsync_bdev with sync_blockdev since no one opens
it.(4/4)

V2:
	- take another approach to avoid failing of zram_remove()
	- add patch to address race between zram_reset_device() and
	  disksize_store()
Thanks for breaking the problems down, Ming.

To me, the whole patchset looks good to me since each patch solves
the problem step by step and finally fix.

Luis, do you have any concern of this patchset to solve the cpuhp
problem? (Sorry in advance if I miss some concerns if you raised
in different thread. I'm totally lost).
Running tests against this now. Will report back!

 Luis
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help