Thread (7 messages) 7 messages, 3 authors, 2021-12-13

RE: [PATCH v2] blk-mq: Fix blk_mq_tagset_busy_iter() for shared tags

From: Kashyap Desai <kashyap.desai@broadcom.com>
Date: 2021-10-18 18:49:19
Also in: lkml

-----Original Message-----
From: John Garry [mailto:john.garry@huawei.com]
Sent: Monday, October 18, 2021 3:11 PM
To: axboe@kernel.dk
Cc: ming.lei@redhat.com; linux-block@vger.kernel.org; linux-
kernel@vger.kernel.org; kashyap.desai@broadcom.com; hare@suse.de; John
Garry [off-list ref]
Subject: [PATCH v2] blk-mq: Fix blk_mq_tagset_busy_iter() for shared
tags
Since it is now possible for a tagset to share a single set of tags, the
iter
function should not re-iter the tags for the count of #hw queues in that
case.
Rather it should just iter once.

Fixes: e0fdf846c7bb ("blk-mq: Use shared tags for shared sbitmap
support")
Reported-by: Kashyap Desai <kashyap.desai@broadcom.com>
Signed-off-by: John Garry <redacted>
Reviewed-by: Ming Lei <redacted>
---
Diff to v1:
- Add Ming's RB tag
Now I noticed proper host_busy in my test. Still CPU hogging is not
resolved, but issue addressed by this patch is resolved.

Tested-by: Kashyap Desai <kashyap.desai@broadcom.com>

Attachments

  • smime.p7s [application/pkcs7-signature] 4212 bytes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help