Re: [PATCH 09/18] ledtrig-blkdev: Periodically check devices for activity &... | linux-block

[PATCH 00/18] Introduce block device LED trigger · Ian Pilcher <hidden> · 2021-09-03
[PATCH 01/18] docs: Add block device (blkdev) LED trigger documentation · Ian Pilcher <hidden> · 2021-09-03
Re: [PATCH 01/18] docs: Add block device (blkdev) LED trigger documentation · Pavel Machek <hidden> · 2021-09-04
Re: [PATCH 01/18] docs: Add block device (blkdev) LED trigger documentation · Ian Pilcher <hidden> · 2021-09-05
Re: [PATCH 01/18] docs: Add block device (blkdev) LED trigger documentation · Pavel Machek <hidden> · 2021-09-05
Re: [PATCH 01/18] docs: Add block device (blkdev) LED trigger documentation · Ian Pilcher <hidden> · 2021-09-05
[PATCH 02/18] ledtrig-blkdev: Add build infra for block device LED trigger · Ian Pilcher <hidden> · 2021-09-03
[PATCH 03/18] ledtrig-blkdev: Add function placeholders needed by block changes · Ian Pilcher <hidden> · 2021-09-03
Re: [PATCH 03/18] ledtrig-blkdev: Add function placeholders needed by block changes · kernel test robot <hidden> · 2021-09-04
[PATCH 04/18] block: Add block device LED trigger integrations · Ian Pilcher <hidden> · 2021-09-03
[PATCH 05/18] ledtrig-blkdev: Implement functions called from block subsystem · Ian Pilcher <hidden> · 2021-09-03
[PATCH 06/18] ledtrig-blkdev: Add function to get gendisk by name · Ian Pilcher <hidden> · 2021-09-03
[PATCH 07/18] ledtrig-blkdev: Add constants, data types, and global variables · Ian Pilcher <hidden> · 2021-09-03
[PATCH 08/18] ledtrig-blkdev: Add miscellaneous helper functions · Ian Pilcher <hidden> · 2021-09-03
Re: [PATCH 08/18] ledtrig-blkdev: Add miscellaneous helper functions · Greg KH <gregkh@linuxfoundation.org> · 2021-09-04
Re: [PATCH 08/18] ledtrig-blkdev: Add miscellaneous helper functions · Ian Pilcher <hidden> · 2021-09-04
[PATCH 09/18] ledtrig-blkdev: Periodically check devices for activity & blink LEDs · Ian Pilcher <hidden> · 2021-09-03
Re: [PATCH 09/18] ledtrig-blkdev: Periodically check devices for activity & blink LEDs · Greg KH <gregkh@linuxfoundation.org> · 2021-09-04
Re: [PATCH 09/18] ledtrig-blkdev: Periodically check devices for activity & blink LEDs · Ian Pilcher <hidden> · 2021-09-05
Re: [PATCH 09/18] ledtrig-blkdev: Periodically check devices for activity & blink LEDs · Greg KH <gregkh@linuxfoundation.org> · 2021-09-05
Re: [PATCH 09/18] ledtrig-blkdev: Periodically check devices for activity & blink LEDs · Ian Pilcher <hidden> · 2021-09-05
Re: [PATCH 09/18] ledtrig-blkdev: Periodically check devices for activity & blink LEDs · Greg KH <gregkh@linuxfoundation.org> · 2021-09-05
Re: [PATCH 09/18] ledtrig-blkdev: Periodically check devices for activity & blink LEDs · Eric Biggers <ebiggers@kernel.org> · 2021-09-05
[PATCH 10/18] ledtrig-blkdev: Add function to associate the trigger with an LED · Ian Pilcher <hidden> · 2021-09-03
[PATCH 12/18] ledtrig-blkdev: Add function to remove LED/device association · Ian Pilcher <hidden> · 2021-09-03
[PATCH 11/18] ledtrig-blkdev: Add function to associate a device with an LED · Ian Pilcher <hidden> · 2021-09-03
[PATCH 13/18] ledtrig-blkdev: Add function to disassociate a device from all LEDs · Ian Pilcher <hidden> · 2021-09-03
[PATCH 14/18] ledtrig-blkdev: Add function to disassociate an LED from the trigger · Ian Pilcher <hidden> · 2021-09-03
[PATCH 16/18] ledtrig-blkdev: Add blink_time & interval sysfs attributes · Ian Pilcher <hidden> · 2021-09-03
[PATCH 15/18] ledtrig-blkdev: Add sysfs attributes to [un]link LEDs & devices · Ian Pilcher <hidden> · 2021-09-03
Re: [PATCH 15/18] ledtrig-blkdev: Add sysfs attributes to [un]link LEDs & devices · Greg KH <gregkh@linuxfoundation.org> · 2021-09-04
Re: [PATCH 15/18] ledtrig-blkdev: Add sysfs attributes to [un]link LEDs & devices · Ian Pilcher <hidden> · 2021-09-04
Re: [PATCH 15/18] ledtrig-blkdev: Add sysfs attributes to [un]link LEDs & devices · Greg KH <gregkh@linuxfoundation.org> · 2021-09-04
Re: [PATCH 15/18] ledtrig-blkdev: Add sysfs attributes to [un]link LEDs & devices · Ian Pilcher <hidden> · 2021-09-04
Re: [PATCH 15/18] ledtrig-blkdev: Add sysfs attributes to [un]link LEDs & devices · Greg KH <gregkh@linuxfoundation.org> · 2021-09-05
Re: [PATCH 15/18] ledtrig-blkdev: Add sysfs attributes to [un]link LEDs & devices · Ian Pilcher <hidden> · 2021-09-05
Re: [PATCH 15/18] ledtrig-blkdev: Add sysfs attributes to [un]link LEDs & devices · Greg KH <gregkh@linuxfoundation.org> · 2021-09-05
[PATCH 17/18] ledtrig-blkdev: Add mode (read/write/rw) sysfs attributue · Ian Pilcher <hidden> · 2021-09-03
Re: [PATCH 17/18] ledtrig-blkdev: Add mode (read/write/rw) sysfs attributue · Greg KH <gregkh@linuxfoundation.org> · 2021-09-04
Re: [PATCH 17/18] ledtrig-blkdev: Add mode (read/write/rw) sysfs attributue · Ian Pilcher <hidden> · 2021-09-04
Re: [PATCH 17/18] ledtrig-blkdev: Add mode (read/write/rw) sysfs attributue · Greg KH <gregkh@linuxfoundation.org> · 2021-09-05
[PATCH 18/18] ledtrig-blkdev: Add initialization & exit functions · Ian Pilcher <hidden> · 2021-09-03
Re: [PATCH 00/18] Introduce block device LED trigger · Pavel Machek <hidden> · 2021-09-04

Re: [PATCH 09/18] ledtrig-blkdev: Periodically check devices for activity & blink LEDs

From: Greg KH <gregkh@linuxfoundation.org>
Date: 2021-09-05 14:51:56
Also in: linux-leds

On Sun, Sep 05, 2021 at 09:39:57AM -0500, Ian Pilcher wrote:

On 9/4/21 1:01 AM, Greg KH wrote:

quoted

Please never use WARN_ON() in new code unless the machine is really
broken and you can not do anything else here.

Wait what?  I thought that was BUG_ON.

Not whan panic-on-warn is set, which is getting more and more common
these days.

thanks,

greg k-h

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help