Re: [PATCH 13/13] xfs: convert xfs_sysfs attrs to use ->seq_show

From: Christoph Hellwig <hch@lst.de>
Date: 2021-09-14 15:30:17
Also in: linux-fsdevel, linux-xfs, lkml
Reply to: Greg Kroah-Hartman, 2021-09-14

On Tue, Sep 14, 2021 at 05:28:08PM +0200, Greg Kroah-Hartman wrote:

We can "force" it by not allowing buffers to be bigger than that, which
is what the code has always done.  I think we want to keep that for now
and not add the new seq_show api.

The buffer already is not larger than that.  The problem is that
sysfs_emit does not actually work for the non-trivial attributes,
which generally are the source of bugs.

Christoph Hellwig · 2021-09-13
[PATCH 01/13] seq_file: mark seq_get_buf as deprecated · Christoph Hellwig · 2021-09-13
Re: [PATCH 01/13] seq_file: mark seq_get_buf as deprecated · Christian Brauner · 2021-09-13
Re: [PATCH 01/13] seq_file: mark seq_get_buf as deprecated · Daniel Wagner · 2021-09-13
Re: [PATCH 01/13] seq_file: mark seq_get_buf as deprecated · Tejun Heo · 2021-09-13
[PATCH 02/13] kernfs: remove kernfs_create_file and kernfs_create_file_ns · Christoph Hellwig · 2021-09-13
Re: [PATCH 02/13] kernfs: remove kernfs_create_file and kernfs_create_file_ns · Christian Brauner · 2021-09-13
[PATCH 03/13] kernfs: remove the unused lockdep_key field in struct kernfs_ops · Christoph Hellwig · 2021-09-13
Re: [PATCH 03/13] kernfs: remove the unused lockdep_key field in struct kernfs_ops · Christian Brauner · 2021-09-13
Re: [PATCH 03/13] kernfs: remove the unused lockdep_key field in struct kernfs_ops · Tejun Heo · 2021-09-13
[PATCH 04/13] sysfs: split out binary attribute handling from sysfs_add_file_mode_ns · Christoph Hellwig · 2021-09-13
Re: [PATCH 04/13] sysfs: split out binary attribute handling from sysfs_add_file_mode_ns · Christian Brauner · 2021-09-13
[PATCH 05/13] sysfs: refactor sysfs_add_file_mode_ns · Christoph Hellwig · 2021-09-13
Re: [PATCH 05/13] sysfs: refactor sysfs_add_file_mode_ns · Christian Brauner · 2021-09-13
[PATCH 06/13] sysfs: simplify sysfs_kf_seq_show · Christoph Hellwig · 2021-09-13
[PATCH 07/13] sysfs: add ->seq_show support to sysfs_ops · Christoph Hellwig · 2021-09-13
Re: [PATCH 07/13] sysfs: add ->seq_show support to sysfs_ops · Christian Brauner · 2021-09-13
[PATCH 08/13] block: convert the blk_mq_hw_ctx attrs to use ->seq_show · Christoph Hellwig · 2021-09-13
[PATCH 09/13] block: convert the blk_integrity attrs to use ->seq_show · Christoph Hellwig · 2021-09-13
[PATCH 10/13] block: convert the request_queue attrs to use ->seq_show · Christoph Hellwig · 2021-09-13
[PATCH 11/13] block: convert the elevator_queue attrs to use ->seq_show · Christoph Hellwig · 2021-09-13
[PATCH 12/13] xfs: convert xfs_errortag attrs to use ->seq_show · Christoph Hellwig · 2021-09-13
[PATCH 13/13] xfs: convert xfs_sysfs attrs to use ->seq_show · Christoph Hellwig · 2021-09-13
Re: [PATCH 13/13] xfs: convert xfs_sysfs attrs to use ->seq_show · Greg Kroah-Hartman · 2021-09-13
Re: [PATCH 13/13] xfs: convert xfs_sysfs attrs to use ->seq_show · Dave Chinner · 2021-09-14
Re: [PATCH 13/13] xfs: convert xfs_sysfs attrs to use ->seq_show · Greg Kroah-Hartman · 2021-09-14
Re: [PATCH 13/13] xfs: convert xfs_sysfs attrs to use ->seq_show · Dave Chinner · 2021-09-14
Re: [PATCH 13/13] xfs: convert xfs_sysfs attrs to use ->seq_show · Christoph Hellwig · 2021-09-14
Re: [PATCH 13/13] xfs: convert xfs_sysfs attrs to use ->seq_show · Greg Kroah-Hartman · 2021-09-14
Re: [PATCH 13/13] xfs: convert xfs_sysfs attrs to use ->seq_show · Christoph Hellwig · 2021-09-14
Re: [PATCH 13/13] xfs: convert xfs_sysfs attrs to use ->seq_show · Greg Kroah-Hartman · 2021-09-14
Re: [PATCH 13/13] xfs: convert xfs_sysfs attrs to use ->seq_show · Christoph Hellwig · 2021-09-15
Re: [PATCH 13/13] xfs: convert xfs_sysfs attrs to use ->seq_show · Greg Kroah-Hartman · 2021-09-15
Bart Van Assche · 2021-09-13
Greg Kroah-Hartman · 2021-09-13
Bart Van Assche · 2021-09-14
Tejun Heo · 2021-09-13
View all 37 messages

`h`	back out one level
`j`	next message in thread / next series-diff position
`k`	previous message in thread / previous series-diff position
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help