Re: [PATCH v3 14/20] mm: introduce FOLL_PCI_P2PDMA to gate getting PCI P2PDMA pages

[PATCH v3 00/20] Userspace P2PDMA with O_DIRECT NVMe devices · Logan Gunthorpe <logang@deltatee.com> · 2021-09-16
[PATCH v3 02/20] PCI/P2PDMA: attempt to set map_type if it has not been set · Logan Gunthorpe <logang@deltatee.com> · 2021-09-16
Re: [PATCH v3 02/20] PCI/P2PDMA: attempt to set map_type if it has not been set · Bjorn Helgaas <helgaas@kernel.org> · 2021-09-27
[PATCH v3 03/20] PCI/P2PDMA: make pci_p2pdma_map_type() non-static · Logan Gunthorpe <logang@deltatee.com> · 2021-09-16
Re: [PATCH v3 03/20] PCI/P2PDMA: make pci_p2pdma_map_type() non-static · Bjorn Helgaas <helgaas@kernel.org> · 2021-09-27
Re: [PATCH v3 03/20] PCI/P2PDMA: make pci_p2pdma_map_type() non-static · Jason Gunthorpe <jgg@ziepe.ca> · 2021-09-28
[PATCH v3 01/20] lib/scatterlist: add flag for indicating P2PDMA segments in an SGL · Logan Gunthorpe <logang@deltatee.com> · 2021-09-16
Re: [PATCH v3 01/20] lib/scatterlist: add flag for indicating P2PDMA segments in an SGL · Jason Gunthorpe <jgg@ziepe.ca> · 2021-09-28
Re: [PATCH v3 01/20] lib/scatterlist: add flag for indicating P2PDMA segments in an SGL · Logan Gunthorpe <logang@deltatee.com> · 2021-09-29
Re: [PATCH v3 01/20] lib/scatterlist: add flag for indicating P2PDMA segments in an SGL · Chaitanya Kulkarni <hidden> · 2021-09-30
Re: [PATCH v3 01/20] lib/scatterlist: add flag for indicating P2PDMA segments in an SGL · Logan Gunthorpe <logang@deltatee.com> · 2021-09-30
Re: [PATCH v3 01/20] lib/scatterlist: add flag for indicating P2PDMA segments in an SGL · Chaitanya Kulkarni <hidden> · 2021-09-30
[PATCH v3 04/20] PCI/P2PDMA: introduce helpers for dma_map_sg implementations · Logan Gunthorpe <logang@deltatee.com> · 2021-09-16
Re: [PATCH v3 04/20] PCI/P2PDMA: introduce helpers for dma_map_sg implementations · Bjorn Helgaas <helgaas@kernel.org> · 2021-09-27
Re: [PATCH v3 04/20] PCI/P2PDMA: introduce helpers for dma_map_sg implementations · Logan Gunthorpe <logang@deltatee.com> · 2021-09-27
Re: [PATCH v3 04/20] PCI/P2PDMA: introduce helpers for dma_map_sg implementations · Jason Gunthorpe <jgg@ziepe.ca> · 2021-09-28
Re: [PATCH v3 04/20] PCI/P2PDMA: introduce helpers for dma_map_sg implementations · Logan Gunthorpe <logang@deltatee.com> · 2021-09-29
Re: [PATCH v3 4/20] PCI/P2PDMA: introduce helpers for dma_map_sg implementations · Jason Gunthorpe <jgg@nvidia.com> · 2021-09-28
Re: [PATCH v3 4/20] PCI/P2PDMA: introduce helpers for dma_map_sg implementations · Logan Gunthorpe <logang@deltatee.com> · 2021-09-29
Re: [PATCH v3 4/20] PCI/P2PDMA: introduce helpers for dma_map_sg implementations · Jason Gunthorpe <jgg@nvidia.com> · 2021-09-29
Re: [PATCH v3 4/20] PCI/P2PDMA: introduce helpers for dma_map_sg implementations · Logan Gunthorpe <logang@deltatee.com> · 2021-09-29
Re: [PATCH v3 4/20] PCI/P2PDMA: introduce helpers for dma_map_sg implementations · Jason Gunthorpe <jgg@nvidia.com> · 2021-09-29
[PATCH v3 19/20] PCI/P2PDMA: introduce pci_mmap_p2pmem() · Logan Gunthorpe <logang@deltatee.com> · 2021-09-16
Re: [PATCH v3 19/20] PCI/P2PDMA: introduce pci_mmap_p2pmem() · Bjorn Helgaas <helgaas@kernel.org> · 2021-09-27
Re: [PATCH v3 19/20] PCI/P2PDMA: introduce pci_mmap_p2pmem() · Jason Gunthorpe <jgg@ziepe.ca> · 2021-09-28
Re: [PATCH v3 19/20] PCI/P2PDMA: introduce pci_mmap_p2pmem() · Logan Gunthorpe <logang@deltatee.com> · 2021-09-29
Re: [PATCH v3 19/20] PCI/P2PDMA: introduce pci_mmap_p2pmem() · Jason Gunthorpe <jgg@ziepe.ca> · 2021-09-29
Re: [PATCH v3 19/20] PCI/P2PDMA: introduce pci_mmap_p2pmem() · Logan Gunthorpe <logang@deltatee.com> · 2021-09-29
Re: [PATCH v3 19/20] PCI/P2PDMA: introduce pci_mmap_p2pmem() · Jason Gunthorpe <jgg@ziepe.ca> · 2021-09-29
Re: [PATCH v3 19/20] PCI/P2PDMA: introduce pci_mmap_p2pmem() · Logan Gunthorpe <logang@deltatee.com> · 2021-09-29
Re: [PATCH v3 19/20] PCI/P2PDMA: introduce pci_mmap_p2pmem() · Jason Gunthorpe <jgg@ziepe.ca> · 2021-09-30
Re: [PATCH v3 19/20] PCI/P2PDMA: introduce pci_mmap_p2pmem() · Jason Gunthorpe <jgg@ziepe.ca> · 2021-10-01
Re: [PATCH v3 19/20] PCI/P2PDMA: introduce pci_mmap_p2pmem() · Logan Gunthorpe <logang@deltatee.com> · 2021-10-01
Re: [PATCH v3 19/20] PCI/P2PDMA: introduce pci_mmap_p2pmem() · Jason Gunthorpe <jgg@ziepe.ca> · 2021-10-01
Re: [PATCH v3 19/20] PCI/P2PDMA: introduce pci_mmap_p2pmem() · Logan Gunthorpe <logang@deltatee.com> · 2021-10-01
Re: [PATCH v3 19/20] PCI/P2PDMA: introduce pci_mmap_p2pmem() · Jason Gunthorpe <jgg@ziepe.ca> · 2021-10-01
Re: [PATCH v3 19/20] PCI/P2PDMA: introduce pci_mmap_p2pmem() · Logan Gunthorpe <logang@deltatee.com> · 2021-10-01
Re: [PATCH v3 19/20] PCI/P2PDMA: introduce pci_mmap_p2pmem() · Jason Gunthorpe <jgg@ziepe.ca> · 2021-10-01
Re: [PATCH v3 19/20] PCI/P2PDMA: introduce pci_mmap_p2pmem() · John Hubbard <jhubbard@nvidia.com> · 2021-10-01
Re: [PATCH v3 19/20] PCI/P2PDMA: introduce pci_mmap_p2pmem() · Logan Gunthorpe <logang@deltatee.com> · 2021-10-01
Re: [PATCH v3 19/20] PCI/P2PDMA: introduce pci_mmap_p2pmem() · Christian König <christian.koenig@amd.com> · 2021-10-04
Re: [PATCH v3 19/20] PCI/P2PDMA: introduce pci_mmap_p2pmem() · Jason Gunthorpe <jgg@ziepe.ca> · 2021-10-04
Re: [PATCH v3 19/20] PCI/P2PDMA: introduce pci_mmap_p2pmem() · Christian König <christian.koenig@amd.com> · 2021-10-04
Re: [PATCH v3 19/20] PCI/P2PDMA: introduce pci_mmap_p2pmem() · Jason Gunthorpe <jgg@ziepe.ca> · 2021-10-04
Re: [PATCH v3 19/20] PCI/P2PDMA: introduce pci_mmap_p2pmem() · Christian König <christian.koenig@amd.com> · 2021-10-04
Re: [PATCH v3 19/20] PCI/P2PDMA: introduce pci_mmap_p2pmem() · Jason Gunthorpe <jgg@ziepe.ca> · 2021-09-28
Re: [PATCH v3 19/20] PCI/P2PDMA: introduce pci_mmap_p2pmem() · Logan Gunthorpe <logang@deltatee.com> · 2021-09-29
[PATCH v3 16/20] block: set FOLL_PCI_P2PDMA in __bio_iov_iter_get_pages() · Logan Gunthorpe <logang@deltatee.com> · 2021-09-16
[PATCH v3 14/20] mm: introduce FOLL_PCI_P2PDMA to gate getting PCI P2PDMA pages · Logan Gunthorpe <logang@deltatee.com> · 2021-09-16
Re: [PATCH v3 14/20] mm: introduce FOLL_PCI_P2PDMA to gate getting PCI P2PDMA pages · Jason Gunthorpe <jgg@ziepe.ca> · 2021-09-28
Re: [PATCH v3 14/20] mm: introduce FOLL_PCI_P2PDMA to gate getting PCI P2PDMA pages · Logan Gunthorpe <logang@deltatee.com> · 2021-09-29
Re: [PATCH v3 14/20] mm: introduce FOLL_PCI_P2PDMA to gate getting PCI P2PDMA pages · Jason Gunthorpe <jgg@ziepe.ca> · 2021-09-29
[PATCH v3 15/20] iov_iter: introduce iov_iter_get_pages_[alloc_]flags() · Logan Gunthorpe <logang@deltatee.com> · 2021-09-16
[PATCH v3 12/20] RDMA/rw: use dma_map_sgtable() · Logan Gunthorpe <logang@deltatee.com> · 2021-09-16
Re: [PATCH v3 12/20] RDMA/rw: use dma_map_sgtable() · Jason Gunthorpe <jgg@ziepe.ca> · 2021-09-28
Re: [PATCH v3 12/20] RDMA/rw: use dma_map_sgtable() · Logan Gunthorpe <logang@deltatee.com> · 2021-09-29
Re: [PATCH v3 12/20] RDMA/rw: use dma_map_sgtable() · Max Gurtovoy <mgurtovoy@nvidia.com> · 2021-10-05
[PATCH v3 13/20] PCI/P2PDMA: remove pci_p2pdma_[un]map_sg() · Logan Gunthorpe <logang@deltatee.com> · 2021-09-16
Re: [PATCH v3 13/20] PCI/P2PDMA: remove pci_p2pdma_[un]map_sg() · Bjorn Helgaas <helgaas@kernel.org> · 2021-09-27
Re: [PATCH v3 13/20] PCI/P2PDMA: remove pci_p2pdma_[un]map_sg() · Jason Gunthorpe <jgg@ziepe.ca> · 2021-09-28
Re: [PATCH v3 13/20] PCI/P2PDMA: remove pci_p2pdma_[un]map_sg() · Max Gurtovoy <mgurtovoy@nvidia.com> · 2021-10-05
[PATCH v3 08/20] iommu/dma: support PCI P2PDMA pages in dma-iommu map_sg · Logan Gunthorpe <logang@deltatee.com> · 2021-09-16
Re: [PATCH v3 08/20] iommu/dma: support PCI P2PDMA pages in dma-iommu map_sg · Jason Gunthorpe <jgg@ziepe.ca> · 2021-09-28
[PATCH v3 09/20] nvme-pci: check DMA ops when indicating support for PCI P2PDMA · Logan Gunthorpe <logang@deltatee.com> · 2021-09-16
Re: [PATCH v3 09/20] nvme-pci: check DMA ops when indicating support for PCI P2PDMA · Chaitanya Kulkarni <hidden> · 2021-09-30
Re: [PATCH v3 09/20] nvme-pci: check DMA ops when indicating support for PCI P2PDMA · Logan Gunthorpe <logang@deltatee.com> · 2021-09-30
Re: [PATCH v3 09/20] nvme-pci: check DMA ops when indicating support for PCI P2PDMA · Chaitanya Kulkarni <hidden> · 2021-09-30
[PATCH v3 07/20] dma-mapping: add flags to dma_map_ops to indicate PCI P2PDMA support · Logan Gunthorpe <logang@deltatee.com> · 2021-09-16
Re: [PATCH v3 07/20] dma-mapping: add flags to dma_map_ops to indicate PCI P2PDMA support · Jason Gunthorpe <jgg@ziepe.ca> · 2021-09-28
[PATCH v3 06/20] dma-direct: support PCI P2PDMA pages in dma-direct map_sg · Logan Gunthorpe <logang@deltatee.com> · 2021-09-16
Re: [PATCH v3 06/20] dma-direct: support PCI P2PDMA pages in dma-direct map_sg · Jason Gunthorpe <jgg@ziepe.ca> · 2021-09-28
[PATCH v3 05/20] dma-mapping: allow EREMOTEIO return code for P2PDMA transfers · Logan Gunthorpe <logang@deltatee.com> · 2021-09-16
Re: [PATCH v3 05/20] dma-mapping: allow EREMOTEIO return code for P2PDMA transfers · Jason Gunthorpe <jgg@ziepe.ca> · 2021-09-28
[PATCH v3 18/20] mm: use custom page_free for P2PDMA pages · Logan Gunthorpe <logang@deltatee.com> · 2021-09-16
[PATCH v3 17/20] block: set FOLL_PCI_P2PDMA in bio_map_user_iov() · Logan Gunthorpe <logang@deltatee.com> · 2021-09-16
[PATCH v3 20/20] nvme-pci: allow mmaping the CMB in userspace · Logan Gunthorpe <logang@deltatee.com> · 2021-09-16
[PATCH v3 11/20] RDMA/core: introduce ib_dma_pci_p2p_dma_supported() · Logan Gunthorpe <logang@deltatee.com> · 2021-09-16
Re: [PATCH v3 11/20] RDMA/core: introduce ib_dma_pci_p2p_dma_supported() · Jason Gunthorpe <jgg@ziepe.ca> · 2021-09-28
Re: [PATCH v3 11/20] RDMA/core: introduce ib_dma_pci_p2p_dma_supported() · Max Gurtovoy <mgurtovoy@nvidia.com> · 2021-10-05
[PATCH v3 10/20] nvme-pci: convert to using dma_map_sgtable() · Logan Gunthorpe <logang@deltatee.com> · 2021-09-16
Re: [PATCH v3 10/20] nvme-pci: convert to using dma_map_sgtable() · Max Gurtovoy <mgurtovoy@nvidia.com> · 2021-10-05
Re: [PATCH v3 00/20] Userspace P2PDMA with O_DIRECT NVMe devices · Jason Gunthorpe <jgg@ziepe.ca> · 2021-09-28
Re: [PATCH v3 00/20] Userspace P2PDMA with O_DIRECT NVMe devices · Logan Gunthorpe <logang@deltatee.com> · 2021-09-29
Re: [PATCH v3 00/20] Userspace P2PDMA with O_DIRECT NVMe devices · Jason Gunthorpe <jgg@ziepe.ca> · 2021-09-29
Re: [PATCH v3 00/20] Userspace P2PDMA with O_DIRECT NVMe devices · Logan Gunthorpe <logang@deltatee.com> · 2021-09-29
Re: [PATCH v3 00/20] Userspace P2PDMA with O_DIRECT NVMe devices · Jason Gunthorpe <jgg@ziepe.ca> · 2021-09-29
Re: [PATCH v3 00/20] Userspace P2PDMA with O_DIRECT NVMe devices · Logan Gunthorpe <logang@deltatee.com> · 2021-09-29

From: Jason Gunthorpe <jgg@ziepe.ca>
Date: 2021-09-28 19:47:12
Also in: linux-iommu, linux-mm, linux-nvme, linux-pci, lkml

On Thu, Sep 16, 2021 at 05:40:54PM -0600, Logan Gunthorpe wrote:

Callers that expect PCI P2PDMA pages can now set FOLL_PCI_P2PDMA to
allow obtaining P2PDMA pages. If a caller does not set this flag
and tries to map P2PDMA pages it will fail.

This is implemented by adding a flag and a check to get_dev_pagemap().

I would like to see the get_dev_pagemap() deleted from GUP in the
first place.

Why isn't this just a simple check of the page->pgmap type after
acquiring a valid page reference? See my prior note

Jason

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help