Re: [PATCH v4 12/13] blk-mq: Use shared tags for shared sbitmap support
From: John Garry <hidden>
Date: 2021-09-27 09:38:19
Also in:
linux-scsi, lkml
From: John Garry <hidden>
Date: 2021-09-27 09:38:19
Also in:
linux-scsi, lkml
On 27/09/2021 10:26, Ming Lei wrote:
quoted
quoted
quoted
- struct sbitmap_queue sched_bitmap_tags; - struct sbitmap_queue sched_breserved_tags; + struct blk_mq_tags *shared_sbitmap_tags;Maybe better with shared_sched_sbitmap_tags or sched_sbitmap_tags?Yeah, I suppose I should add "sched" to the name, as before. BTW, Do you think that I should just change shared_sbitmap -> shared_tags naming now globally? I'm thinking now that I should...Yeah, I think so, but seems you preferred to the name of shared sbitmap, so I did't mention that,:-)
OK, I can clear up any references in a follow on patch to try to keep this one as small as possible. Thanks, John