Thread (6 messages) 6 messages, 4 authors, 2021-09-06

Re: [PATCH] block/mq-deadline: Move dd_queued() to fix defined but not used warning

From: Bart Van Assche <bvanassche@acm.org>
Date: 2021-08-30 23:22:21
Also in: lkml

On 8/30/21 2:11 AM, Geert Uytterhoeven wrote:
If CONFIG_BLK_DEBUG_FS=n:

     block/mq-deadline.c:274:12: warning: ‘dd_queued’ defined but not used [-Wunused-function]
       274 | static u32 dd_queued(struct deadline_data *dd, enum dd_prio prio)
	  |            ^~~~~~~~~

Fix this by moving dd_queued() just before the sole function that calls
it.

Fixes: 7b05bf771084ff78 ("Revert "block/mq-deadline: Prioritize high-priority requests"")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
The Fixes tag probably should be changed into the following:

Fixes: 38ba64d12d4c ("block/mq-deadline: Track I/O statistics")

Anyway:

Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help