Thread (108 messages) 108 messages, 22 authors, 2021-11-24

Re: [PATCH v2 56/63] RDMA/mlx5: Use struct_group() to zero struct mlx5_ib_mr

From: Kees Cook <hidden>
Date: 2021-08-20 15:56:36
Also in: dri-devel, linux-hardening, linux-kbuild, linux-rdma, linux-staging, linux-wireless, lkml, netdev

On Fri, Aug 20, 2021 at 09:34:00AM -0300, Jason Gunthorpe wrote:
On Thu, Aug 19, 2021 at 11:14:37AM -0700, Kees Cook wrote:
quoted
Which do you mean? When doing the conversions I tended to opt for
struct_group() since it provides more robust "intentionality". Strictly
speaking, the new memset helpers are doing field-spanning writes, but the
"clear to the end" pattern was so common it made sense to add the helpers,
as they're a bit less disruptive. It's totally up to you! :)
Well, of the patches you cc'd to me only this one used the struct
group..
Understood. I've adjusted this for v3. Thanks!

-- 
Kees Cook
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help