Re: [PATCH v2 03/11] blk-mq: Relocate shared sbitmap resize in blk_mq_update_nr_requests()
From: Ming Lei <hidden>
Date: 2021-08-18 03:50:11
Also in:
linux-scsi, lkml
From: Ming Lei <hidden>
Date: 2021-08-18 03:50:11
Also in:
linux-scsi, lkml
On Mon, Aug 09, 2021 at 10:29:30PM +0800, John Garry wrote:
For shared sbitmap, if the call to blk_mq_tag_update_depth() was successful for any hctx when hctx->sched_tags is not set, then it would be successful for all (due to nature in which blk_mq_tag_update_depth() fails). As such, there is no need to call blk_mq_tag_resize_shared_sbitmap() for each hctx. So relocate the call until after the hctx iteration under the !q->elevator check, which is equivalent (to !hctx->sched_tags). Signed-off-by: John Garry <redacted>
Reviewed-by: Ming Lei <redacted> -- Ming