Re: [Patch v5 2/3] Drivers: hv: add Azure Blob driver
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2021-08-05 07:11:39
Also in:
linux-doc, linux-hyperv, lkml
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2021-08-05 07:11:39
Also in:
linux-doc, linux-hyperv, lkml
On Thu, Aug 05, 2021 at 12:00:11AM -0700, longli@linuxonhyperv.com wrote:
+static int az_blob_create_device(struct az_blob_device *dev)
+{
+ int ret;
+ struct dentry *debugfs_root;
+
+ dev->misc.minor = MISC_DYNAMIC_MINOR,
+ dev->misc.name = "azure_blob",
+ dev->misc.fops = &az_blob_client_fops,
+
+ ret = misc_register(&dev->misc);
+ if (ret)
+ return ret;
+
+ debugfs_root = debugfs_create_dir("az_blob", NULL);So you try to create a directory in the root of debugfs called "az_blob" for every device in the system of this one type? That will blow up when you have multiple devices of the same type, please fix. thanks, greg k-h