Thread (11 messages) flat view 11 messages, 4 authors, 2021-07-22

Re: [PATCH V5 1/3] driver core: add device_has_managed_msi_irq

From: Christoph Hellwig <hch@lst.de>
Date: 2021-07-21 14:36:20

On Wed, Jul 21, 2021 at 05:17:21PM +0800, Ming Lei wrote:
+bool device_has_managed_msi_irq(struct device *dev)
+{
+	struct msi_desc *desc;
+
+	if (IS_ENABLED(CONFIG_GENERIC_MSI_IRQ)) {
And inline stub for the !CONFIG_GENERIC_MSI_IRQ would seem nicer
so that we don't even nee the call.

Also please add a kerneldoc comment, and as Greg said this probably
doesn't belong into drivers/base and device.h but something in the
irq layer.  Maybe Thomas has a preference.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help