Thread (25 messages) 25 messages, 6 authors, 2021-07-30

Re: [RFC PATCH 1/8] docs: Add block device LED trigger documentation

From: Valdis Klētnieks <hidden>
Date: 2021-07-29 03:09:22
Also in: kernelnewbies, linux-leds, lkml

On Wed, 28 Jul 2021 20:53:37 -0500, Ian Pilcher said:
+Create a new block device LED trigger::
+
+	# echo foo > /sys/class/block/led_trigger_new
+
+The name must be unique among all LED triggers (not just block device LED
+triggers).
+
+Create two more::
+
+	# echo bar baz > /sys/class/block/led_trigger_new
+	# cat /sys/class/block/led_trigger_list
+	baz: 0
+	bar: 0
+	foo: 0
This looks like an abuse of the "one entry one value" rule for sysfs.
Perhaps this should be a directory /sys/class/block/defined_triggers/
and separate files under that for foo, bar, and baz?  That would probably
make reference counting a lot easier as well....

Attachments

  • (unnamed) [application/pgp-signature] 494 bytes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help