Re: [RFC 3/6] md: replace GENHD_FL_UP with GENHD_FL_DISK_ADDED on is_mddev_broken()
From: Luis Chamberlain <mcgrof@kernel.org>
Date: 2021-07-16 20:02:41
Also in:
lkml
On Fri, Jul 16, 2021 at 07:51:00AM +0200, Hannes Reinecke wrote:
On 7/15/21 10:23 PM, Luis Chamberlain wrote:quoted
The GENHD_FL_DISK_ADDED flag is what we really want, as the flag GENHD_FL_UP could be set on a semi-initialized device. Signed-off-by: Luis Chamberlain <mcgrof@kernel.org> --- drivers/md/md.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/md/md.h b/drivers/md/md.h index 832547cf038f..80561bca1f51 100644 --- a/drivers/md/md.h +++ b/drivers/md/md.h@@ -766,7 +766,7 @@ static inline bool is_mddev_broken(struct md_rdev *rdev, const char *md_type) { int flags = rdev->bdev->bd_disk->flags; - if (!(flags & GENHD_FL_UP)) { + if (!(flags & GENHD_FL_DISK_ADDED)) { if (!test_and_set_bit(MD_BROKEN, &rdev->mddev->flags)) pr_warn("md: %s: %s array has a missing/failed member\n", mdname(rdev->mddev), md_type);Why again did you introduce the wrapper? Shouldn't it be used here?
Indeed, and that lets us remove the flag copy. Will fix. Thanks for the review. Luis