Re: [PATCH v2 5/6] block: add initial error handling for *add_disk()* and friends
From: Christoph Hellwig <hch@infradead.org>
Date: 2021-07-15 07:59:00
Also in:
lkml
From: Christoph Hellwig <hch@infradead.org>
Date: 2021-07-15 07:59:00
Also in:
lkml
-static inline void add_disk(struct gendisk *disk)
+extern int device_add_disk(struct device *parent, struct gendisk *disk,
+ const struct attribute_group **groups);
+static inline int add_disk(struct gendisk *disk)
{
- device_add_disk(NULL, disk, NULL);
+ return device_add_disk(NULL, disk, NULL);
}
-extern void device_add_disk_no_queue_reg(struct device *parent, struct gendisk *disk);
-static inline void add_disk_no_queue_reg(struct gendisk *disk)
+extern int device_add_disk_no_queue_reg(struct device *parent, struct gendisk *disk);Nit: please drop the pointless externs and avoid > 80 character lines.