Thread (47 messages) 47 messages, 9 authors, 2021-06-15

Re: [PATCH 09/30] mtd_blkdevs: use blk_mq_alloc_disk

From: Christoph Hellwig <hch@lst.de>
Date: 2021-06-15 15:59:05
Also in: ceph-devel, dm-devel, linux-mmc, linux-s390, linuxppc-dev, virtualization, xen-devel
Subsystem: memory technology devices (mtd), the rest · Maintainers: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra, Linus Torvalds

On Tue, Jun 15, 2021 at 05:47:44PM +0200, Marek Szyprowski wrote:
Hi,

On 02.06.2021 08:53, Christoph Hellwig wrote:
quoted
Use the blk_mq_alloc_disk API to simplify the gendisk and request_queue
allocation.

Signed-off-by: Christoph Hellwig <hch@lst.de>
This patch landed in linux-next as commit 6966bb921def ("mtd_blkdevs: 
use blk_mq_alloc_disk"). It causes the following regression on my QEMU 
arm64 setup:
Please try the patch below:
diff --git a/drivers/mtd/mtd_blkdevs.c b/drivers/mtd/mtd_blkdevs.c
index 5dc4c966ea73..6ce4bc57f919 100644
--- a/drivers/mtd/mtd_blkdevs.c
+++ b/drivers/mtd/mtd_blkdevs.c
@@ -382,6 +382,7 @@ int add_mtd_blktrans_dev(struct mtd_blktrans_dev *new)
 	}
 
 	new->disk = gd;
+	new->rq = new->disk->queue;
 	gd->private_data = new;
 	gd->major = tr->major;
 	gd->first_minor = (new->devnum) << tr->part_bits;
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help