Re: [PATCH v3 1/6] block: add disk sequence number

[PATCH v3 0/6] block: add a sequence number to disks · Matteo Croce <hidden> · 2021-06-23
[PATCH v3 1/6] block: add disk sequence number · Matteo Croce <hidden> · 2021-06-23
Re: [PATCH v3 1/6] block: add disk sequence number · Christoph Hellwig <hch@infradead.org> · 2021-06-23
Re: [PATCH v3 1/6] block: add disk sequence number · Matteo Croce <hidden> · 2021-06-23
Re: [PATCH v3 1/6] block: add disk sequence number · Lennart Poettering <hidden> · 2021-06-23
Re: [PATCH v3 1/6] block: add disk sequence number · Hannes Reinecke <hare@suse.de> · 2021-06-23
Re: [PATCH v3 1/6] block: add disk sequence number · Luca Boccassi <hidden> · 2021-06-23
Re: [PATCH v3 1/6] block: add disk sequence number · Hannes Reinecke <hare@suse.de> · 2021-06-23
Re: [PATCH v3 1/6] block: add disk sequence number · Luca Boccassi <hidden> · 2021-06-23
Re: [PATCH v3 1/6] block: add disk sequence number · Lennart Poettering <hidden> · 2021-06-23
Re: [PATCH v3 1/6] block: add disk sequence number · Lennart Poettering <hidden> · 2021-06-23
Re: [PATCH v3 1/6] block: add disk sequence number · Hannes Reinecke <hare@suse.de> · 2021-06-23
Re: [PATCH v3 1/6] block: add disk sequence number · Luca Boccassi <hidden> · 2021-06-23
Re: [PATCH v3 1/6] block: add disk sequence number · Lennart Poettering <hidden> · 2021-06-23
Re: [PATCH v3 1/6] block: add disk sequence number · Christoph Hellwig <hch@infradead.org> · 2021-06-23
[PATCH v3 2/6] block: add ioctl to read the disk sequence number · Matteo Croce <hidden> · 2021-06-23
[PATCH v3 3/6] block: refactor sysfs code · Matteo Croce <hidden> · 2021-06-23
Re: [PATCH v3 3/6] block: refactor sysfs code · Christoph Hellwig <hch@infradead.org> · 2021-06-23
Re: [PATCH v3 3/6] block: refactor sysfs code · Matteo Croce <hidden> · 2021-06-23
Re: [PATCH v3 3/6] block: refactor sysfs code · Christoph Hellwig <hch@infradead.org> · 2021-06-24
[PATCH v3 4/6] block: export diskseq in sysfs · Matteo Croce <hidden> · 2021-06-23
[PATCH v3 5/6] block: increment sequence number · Matteo Croce <hidden> · 2021-06-23
[PATCH v3 6/6] loop: increment sequence number · Matteo Croce <hidden> · 2021-06-23
Re: [PATCH v3 6/6] loop: increment sequence number · Christoph Hellwig <hch@infradead.org> · 2021-06-23
Re: [PATCH v3 6/6] loop: increment sequence number · Luca Boccassi <hidden> · 2021-06-23
Re: [PATCH v3 6/6] loop: increment sequence number · Christoph Hellwig <hch@infradead.org> · 2021-06-23
Re: [PATCH v3 6/6] loop: increment sequence number · Lennart Poettering <hidden> · 2021-06-23
Re: [PATCH v3 6/6] loop: increment sequence number · Christoph Hellwig <hch@infradead.org> · 2021-06-24
Re: [PATCH v3 0/6] block: add a sequence number to disks · Hannes Reinecke <hare@suse.de> · 2021-06-23
Re: [PATCH v3 0/6] block: add a sequence number to disks · Luca Boccassi <hidden> · 2021-06-23
Re: [PATCH v3 0/6] block: add a sequence number to disks · Lennart Poettering <hidden> · 2021-06-23

From: Christoph Hellwig <hch@infradead.org>
Date: 2021-06-23 11:49:09
Also in: linux-fsdevel, lkml

On Wed, Jun 23, 2021 at 12:58:53PM +0200, Matteo Croce wrote:

+void inc_diskseq(struct gendisk *disk)
+{
+	static atomic64_t diskseq;

Please don't hide file scope variables in functions.

Can you explain a little more why we need a global sequence count vs
a per-disk one here?

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help