Thread (26 messages) 26 messages, 5 authors, 2021-06-23

Re: [PATCH v2 05/10] block: reduce stack footprint dealing with block device names

From: Christoph Hellwig <hch@infradead.org>
Date: 2021-06-23 07:45:46
Also in: linux-fsdevel, lkml

On Tue, Jun 22, 2021 at 08:44:19PM +0300, Anton Suvorov wrote:
Stack usage reduced (measured with allyesconfig):
Not just stack footprint, but also a whole lot cleaner code in general.
-			       bdevname(state->bdev, b), blk);
+			pr_err("Dev %pg: unable to read RDB block %d\n", state->bdev, blk);
-		       bdevname(state->bdev, b), blk);
+		pr_err("Dev %pg: RDB in block %d has bad checksum\n", state->bdev, blk);
-			pr_err("Dev %s: unable to read partition block %d\n",
-			       bdevname(state->bdev, b), blk);
+			pr_err("Dev %pg: unable to read partition block %d\n", state->bdev, blk);
[...]

Please keep the non-format string arguments on separate lines instead
of creating unreadable lines.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help