Re: [PATCH] pstore/blk: Use the normal block device I/O path

From
Al Viro <viro@zeniv.linux.org.uk>
Date
2021-06-14 20:09:57
Also in
linux-fsdevel, lkml
Reply to
Kees Cook, 2021-06-14
On Mon, Jun 14, 2021 at 01:04:21PM -0700, Kees Cook wrote:
  
 static ssize_t psblk_generic_blk_write(const char *buf, size_t bytes,
 		loff_t pos)
 {
 	/* Console/Ftrace backend may handle buffer until flush dirty zones */
 	if (in_interrupt() || irqs_disabled())
 		return -EBUSY;
+	return kernel_write(psblk_file, buf, bytes, &pos);
In which locking environments could that be called?  The checks above
look like that thing could be called from just about any context;
could that happen when the caller is holding a page locked?

IOW, what are those checks really trying to do?
Thread (5 messages) 5 messages, 3 authors, last reply 2021-06-15
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help