Thread (9 messages) 9 messages, 1 author, 2021-06-10
DORMANTno replies

[PATCH 7/8] bfq: reset entity->prio_changed in bfq_init_entity()

From: brookxu <hidden>
Date: 2021-06-10 07:24:27
Also in: lkml
Subsystem: bfq i/o scheduler, block layer, control group - block io controller (blkio), the rest · Maintainers: Yu Kuai, Jens Axboe, Tejun Heo, Josef Bacik, Linus Torvalds

From: Chunguang Xu <redacted>

Since weight, ioprio, ioprio_class will be updated in bfq_init_entity(),
st->wsum will be updated in __bfq_activate_entity(), so when it is first
active, it seems that __bfq_entity_update_weight_prio() has nothing to
do. By resetting entity->prio_change in bfq_init_entity(), we can avoid
unnecessary logic calls.

Signed-off-by: Chunguang Xu <redacted>
---
 block/bfq-cgroup.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/block/bfq-cgroup.c b/block/bfq-cgroup.c
index c8c68dc..79a5aaa 100644
--- a/block/bfq-cgroup.c
+++ b/block/bfq-cgroup.c
@@ -426,6 +426,7 @@ void bfq_init_entity(struct bfq_entity *entity, struct bfq_group *bfqg)
 
 	entity->weight = entity->new_weight;
 	entity->orig_weight = entity->new_weight;
+	entity->prio_changed = 0;
 	if (bfqq) {
 		bfqq->ioprio = bfqq->new_ioprio;
 		bfqq->ioprio_class = bfqq->new_ioprio_class;
-- 
1.8.3.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help