Thread (5 messages) 5 messages, 2 authors, 2021-06-01

[PATCH] blk-mq: update hctx->dispatch_busy in case of real scheduler

flat view
STALE1960d

From: Ming Lei <hidden>
Date: 2021-05-28 03:21:23
Subsystem: block layer, the rest · Maintainers: Jens Axboe, Linus Torvalds

Commit 6e6fcbc27e77 ("blk-mq: support batching dispatch in case of io")
starts to support io batching submission by using hctx->dispatch_busy.

However, blk_mq_update_dispatch_busy() isn't changed to update hctx->dispatch_busy
in that commit, so fix the issue by updating hctx->dispatch_busy in case
of real scheduler.

Reported-by: Jan Kara <jack@suse.cz>
Fixes: 6e6fcbc27e77 ("blk-mq: support batching dispatch in case of io")
Signed-off-by: Ming Lei <redacted>
---
 block/blk-mq.c | 3 ---
 1 file changed, 3 deletions(-)
diff --git a/block/blk-mq.c b/block/blk-mq.c
index f11d4018ce2e..4930f7119f22 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -1224,9 +1224,6 @@ static void blk_mq_update_dispatch_busy(struct blk_mq_hw_ctx *hctx, bool busy)
 {
 	unsigned int ewma;
 
-	if (hctx->queue->elevator)
-		return;
-
 	ewma = hctx->dispatch_busy;
 
 	if (!ewma && !busy)
-- 
2.29.2
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help