Thread (20 messages) 20 messages, 5 authors, 2021-05-27

Re: [RFC PATCH 0/8] block: fix bio_add_XXX_page() return type

flat view

From: Omar Sandoval <osandov@osandov.com>
Date: 2021-05-21 22:37:41
Also in: linux-btrfs, linux-scsi, target-devel

On Fri, May 21, 2021 at 09:37:43PM +0000, Chaitanya Kulkarni wrote:
On 5/21/21 03:25, Johannes Thumshirn wrote:
quoted
I couldn't spot any errors, but I'm not sure it's worth the effort.

If Jens decides to take it:
Reviewed-by: Johannes Thumshirn <redacted>
It does create confusion on the code level which can result in
invalid error checks.
Do you have any examples of bugs caused by this confusion (whether they
were fixed in the past, currently exist, or were caught in code review)?
That would be good justification for doing this.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help