Thread (9 messages) 9 messages, 4 authors, 2021-05-20

Re: [PATCH 1/2] block: prevent block device lookups at the beginning of del_gendisk

flat view

From: Ming Lei <hidden>
Date: 2021-05-15 06:35:20

On Fri, May 14, 2021 at 03:18:41PM +0200, Christoph Hellwig wrote:
As an artifact of how gendisk lookup used to work in earlier kernels,
GENHD_FL_UP is only cleared very late in del_gendisk, and a global lock
is used to prevent opens from succeeding while del_gendisk is tearing
down the gendisk.  Switch to clearing the flag early and under bd_mutex
so that callers can use bd_mutex to stabilize the flag, which removes
the need for the global mutex.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Ming Lei <redacted>

-- 
Ming
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help