Thread (11 messages) flat view 11 messages, 4 authors, 2021-05-13

Re: [PATCH] md: don't account io stat for split bio

From: Guoqing Jiang <hidden>
Date: 2021-05-10 07:47:03
Also in: linux-raid


On 5/10/21 2:00 PM, Christoph Hellwig wrote:
On Sat, May 08, 2021 at 11:48:15AM +0800, Guoqing Jiang wrote:
quoted
It looks like stack overflow happened for split bio, to fix this,
let's keep split bio untouched in md_submit_bio.

As a side effect, we need to export bio_chain_endio.
Err, no.  The right answer is to not change ->bi_end_io of bios that
you do not own instead of using a horrible hack to skip accounting for
bios that have no more or less reason to be accounted than others bios.
Thanks for the reply. I suppose that md needs to revert current
implementation of accounting io stats, then re-implement it.

Song and Artur, what are your opinion?

Thanks,
Guoqing
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help