Re: [PATCH v2 08/22] dma-mapping: Allow map_sg() ops to return negative error codes

[PATCH v2 00/22] Add new DMA mapping operation for P2PDMA · Logan Gunthorpe <logang@deltatee.com> · 2021-05-13
[PATCH v2 02/22] PCI/P2PDMA: Use a buffer on the stack for collecting the acs list · Logan Gunthorpe <logang@deltatee.com> · 2021-05-13
[PATCH v2 01/22] PCI/P2PDMA: Rename upstream_bridge_distance() and rework documentation · Logan Gunthorpe <logang@deltatee.com> · 2021-05-13
[PATCH v2 03/22] PCI/P2PDMA: Cleanup type for return value of calc_map_type_and_dist() · Logan Gunthorpe <logang@deltatee.com> · 2021-05-13
[PATCH v2 04/22] PCI/P2PDMA: Avoid pci_get_slot() which sleeps · Logan Gunthorpe <logang@deltatee.com> · 2021-05-13
[PATCH v2 20/22] RDMA/core: Introduce ib_dma_pci_p2p_dma_supported() · Logan Gunthorpe <logang@deltatee.com> · 2021-05-13
[PATCH v2 18/22] nvme-pci: Check DMA ops when indicating support for PCI P2PDMA · Logan Gunthorpe <logang@deltatee.com> · 2021-05-13
[PATCH v2 21/22] RDMA/rw: use dma_map_sgtable() · Logan Gunthorpe <logang@deltatee.com> · 2021-05-13
[PATCH v2 19/22] nvme-pci: Convert to using dma_map_sgtable() · Logan Gunthorpe <logang@deltatee.com> · 2021-05-13
[PATCH v2 22/22] PCI/P2PDMA: Remove pci_p2pdma_[un]map_sg() · Logan Gunthorpe <logang@deltatee.com> · 2021-05-13
[PATCH v2 17/22] iommu/dma: Support PCI P2PDMA pages in dma-iommu map_sg · Logan Gunthorpe <logang@deltatee.com> · 2021-05-13
[PATCH v2 16/22] dma-mapping: Add flags to dma_map_ops to indicate PCI P2PDMA support · Logan Gunthorpe <logang@deltatee.com> · 2021-05-13
[PATCH v2 14/22] PCI/P2PDMA: Introduce helpers for dma_map_sg implementations · Logan Gunthorpe <logang@deltatee.com> · 2021-05-13
Re: [PATCH v2 14/22] PCI/P2PDMA: Introduce helpers for dma_map_sg implementations · Christoph Hellwig <hch@lst.de> · 2021-05-14
Re: [PATCH v2 14/22] PCI/P2PDMA: Introduce helpers for dma_map_sg implementations · Logan Gunthorpe <logang@deltatee.com> · 2021-05-14
[PATCH v2 15/22] dma-direct: Support PCI P2PDMA pages in dma-direct map_sg · Logan Gunthorpe <logang@deltatee.com> · 2021-05-13
Re: [PATCH v2 15/22] dma-direct: Support PCI P2PDMA pages in dma-direct map_sg · Christoph Hellwig <hch@lst.de> · 2021-05-14
Re: [PATCH v2 15/22] dma-direct: Support PCI P2PDMA pages in dma-direct map_sg · Logan Gunthorpe <logang@deltatee.com> · 2021-05-14
[PATCH v2 08/22] dma-mapping: Allow map_sg() ops to return negative error codes · Logan Gunthorpe <logang@deltatee.com> · 2021-05-13
Re: [PATCH v2 08/22] dma-mapping: Allow map_sg() ops to return negative error codes · Christoph Hellwig <hch@lst.de> · 2021-05-14
Re: [PATCH v2 08/22] dma-mapping: Allow map_sg() ops to return negative error codes · Logan Gunthorpe <logang@deltatee.com> · 2021-05-14
[PATCH v2 07/22] PCI/P2PDMA: Refactor pci_p2pdma_map_type() to take pagemap and device · Logan Gunthorpe <logang@deltatee.com> · 2021-05-13
[PATCH v2 09/22] dma-direct: Return appropriate error code from dma_direct_map_sg() · Logan Gunthorpe <logang@deltatee.com> · 2021-05-13
[PATCH v2 10/22] iommu: Return full error code from iommu_map_sg[_atomic]() · Logan Gunthorpe <logang@deltatee.com> · 2021-05-13
[PATCH v2 11/22] dma-iommu: Return error code from iommu_dma_map_sg() · Logan Gunthorpe <logang@deltatee.com> · 2021-05-13
[PATCH v2 12/22] lib/scatterlist: Add flag for indicating P2PDMA segments in an SGL · Logan Gunthorpe <logang@deltatee.com> · 2021-05-13
[PATCH v2 13/22] PCI/P2PDMA: Make pci_p2pdma_map_type() non-static · Logan Gunthorpe <logang@deltatee.com> · 2021-05-13
[PATCH v2 06/22] PCI/P2PDMA: Attempt to set map_type if it has not been set · Logan Gunthorpe <logang@deltatee.com> · 2021-05-13
Re: [PATCH v2 06/22] PCI/P2PDMA: Attempt to set map_type if it has not been set · Christoph Hellwig <hch@lst.de> · 2021-05-14
Re: [PATCH v2 06/22] PCI/P2PDMA: Attempt to set map_type if it has not been set · Logan Gunthorpe <logang@deltatee.com> · 2021-05-14
[PATCH v2 05/22] PCI/P2PDMA: Print a warning if the host bridge is not in the whitelist · Logan Gunthorpe <logang@deltatee.com> · 2021-05-13
Re: [PATCH v2 00/22] Add new DMA mapping operation for P2PDMA · Christoph Hellwig <hch@lst.de> · 2021-05-14
Re: [PATCH v2 00/22] Add new DMA mapping operation for P2PDMA · Logan Gunthorpe <logang@deltatee.com> · 2021-05-14

From: Logan Gunthorpe <logang@deltatee.com>
Date: 2021-05-14 16:16:07
Also in: linux-iommu, linux-mm, linux-nvme, linux-pci, lkml


On 2021-05-14 7:51 a.m., Christoph Hellwig wrote:

quoted

+int __dma_map_sg_attrs(struct device *dev, struct scatterlist *sg, int nents,
 		enum dma_data_direction dir, unsigned long attrs);

I don't think it makes sense to expose this __dma_map_sg_attrs helper.
Just keep it static and move the sgtable helper to kernel/dma/mapping.c
as well.

Makes sense. I'll fix this for v3.

Logan

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help