Thread (3 messages) 3 messages, 3 authors, 2021-04-25

Re: [PATCH] blk-mq: Fix two racy hctx->tags->rqs[] assignments

From: Jens Axboe <axboe@kernel.dk>
Date: 2021-04-24 19:33:27

On 4/23/21 2:01 PM, Bart Van Assche wrote:
hctx->tags->rqs[] must be cleared before releasing a request tag because
otherwise clearing that pointer races with the following assignment in
blk_mq_get_driver_tag():

	rcu_assign_pointer(hctx->tags->rqs[rq->tag], rq);
Looks good to me. Applied, and added:

Fixes: 5ba3f5a6ca7e ("blk-mq: Fix races between iterating over requests and freeing requests")

which was missing.

-- 
Jens Axboe
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help