Re: [PATCH v4 3/3] blk-mq: Fix a race between iterating over requests and freeing requests

On 4/2/21 8:37 PM, Khazhy Kumykov wrote:

On Fri, Apr 2, 2021 at 8:26 PM Bart Van Assche [off-list ref] wrote:

quoted

On 4/2/21 4:59 PM, Khazhy Kumykov wrote:

quoted

lockdep_is_held(&tags->iter_rwsem) ?

I will change the second rcu_dereference_check() argument into the
following:

rcu_read_lock_held() || lockdep_is_held(&tags->iter_rwsem)

rcu_dereference_check() already has a || rcu_read_lock_held(), fwiw

From a quick look it seems like other rcu_dereference_check() calls do
not specify rcu_read_lock_held() explicitly so I will leave it out.

Thanks,

Bart.