On Thu, Mar 25, 2021 at 5:12 PM Leon Romanovsky [off-list ref] wrote:

On Thu, Mar 25, 2021 at 04:29:00PM +0100, Gioh Kim wrote:

quoted

From: Gioh Kim <redacted>

They are defined with the same value and similar meaning, let's remove
one of them, then we can remove {WAIT,NOWAIT}.

Also change the type of 'wait' from 'int' to 'enum wait_type' to make
it clear.

Cc: Jason Gunthorpe <redacted>
Cc: Leon Romanovsky <leonro@nvidia.com>
Cc: linux-rdma@vger.kernel.org
Signed-off-by: Guoqing Jiang <redacted>
Reviewed-by: Md Haris Iqbal <haris.iqbal@ionos.com>
Signed-off-by: Gioh Kim <redacted>
Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
---
 drivers/block/rnbd/rnbd-clt.c          | 42 +++++++++++---------------
 drivers/infiniband/ulp/rtrs/rtrs-clt.c |  4 +--
 drivers/infiniband/ulp/rtrs/rtrs.h     |  6 ++--
 3 files changed, 22 insertions(+), 30 deletions(-)

<...>

quoted

@@ -535,7 +527,7 @@ static void msg_open_conf(struct work_struct *work)
                       * If server thinks its fine, but we fail to process
                       * then be nice and send a close to server.
                       */
-                     (void)send_msg_close(dev, device_id, NO_WAIT);
+                     (void)send_msg_close(dev, device_id, RTRS_PERMIT_NOWAIT);

This (void) casting is not needed.

I will fix them.
Thank you.

Thanks