On Fri, Mar 19, 2021 at 01:03:02PM -0700, Randy Dunlap wrote:

Hm, needs some spacing fixes IMO. See below.


On Sat, 20 Mar 2021, Bhaskar Chowdhury wrote:

quoted

s/funtion/functions/

Plus the sentence reconstructed for better readability.

Signed-off-by: Bhaskar Chowdhury <redacted>
---
Changes from V1:
 Randy's suggestions incorporated.

block/blk-mq-tag.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c
index 9c92053e704d..c2bef283db63 100644
--- a/block/blk-mq-tag.c
+++ b/block/blk-mq-tag.c

@@ -373,8 +373,8 @@ static bool blk_mq_tagset_count_completed_rqs(struct request *rq,

}

/**
- * blk_mq_tagset_wait_completed_request - wait until all completed req's
- * complete funtion is run

completion function

That's my read of it.

--Tom

quoted

+ * blk_mq_tagset_wait_completed_request - wait until all the  req's

                                                            the req's

quoted

+ *  functions completed their run

and more indentation + wording on that line above:
 *        functions have completed their run

quoted

 * @tagset:	Tag set to drain completed request
 *
 * Note: This function has to be run after all IO queues are shutdown
--

Thanks.