Re: [PATCH v7 1/3] block: add blk_mq_is_queue_frozen()

From
Sergei Shtepa <hidden>
Date
2021-03-15 12:06:56
Also in
dm-devel, linux-api, lkml
Reply to
Christoph Hellwig, 2021-03-14
The 03/14/2021 12:14, Christoph Hellwig wrote:
On Fri, Mar 12, 2021 at 02:06:41PM -0500, Mike Snitzer wrote:
quoted
This is returning a frozen state that is immediately stale.  I don't
think any code calling this is providing the guarantees you think it
does due to the racey nature of this state once the mutex is dropped.
The code only uses it for asserts in the form of WARN_ONs.
But perhaps it is possible to come up with a more elegant solution?
I'll think about it.
-- 
Sergei Shtepa
Veeam Software developer.
Thread (25 messages) 25 messages, 4 authors, last reply 2021-03-18
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help