Thread (2 messages) 2 messages, 2 authors, 2021-02-26

Re: Stray reference to RQF_SORTED

flat view

From: Jens Axboe <axboe@kernel.dk>
Date: 2021-02-26 18:40:18

On 2/26/21 2:52 AM, Jean Delvare wrote:
Hi Jens,

In commit a1ce35fa49852db60fc6e268038530be533c5b15 ("block: remove dead
elevator code") you removed all users of RQF_SORTED. However there is
still one reference left to it:

block/blk-mq-sched.c:412:               rq->rq_flags |= RQF_SORTED;

This in effect is dead code now. Should this statement have been
removed as part of the aforementioned commit? And then maybe also the
definition of RQF_SORTED, to prevent further confusion?
It's just a leftover, feel free to send a patch to kill it.

-- 
Jens Axboe
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help