Thread (19 messages) 19 messages, 4 authors, 2021-03-25

Re: [RFC PATCH 2/8] brd: use memcpy_from_page() in copy_from_brd()

From: Chaitanya Kulkarni <hidden>
Date: 2021-02-08 05:49:32
Also in: linux-ext4, linux-f2fs-devel, linux-fsdevel

quoted
@@ -236,11 +235,9 @@ static void copy_from_brd(void *dst, struct brd_device *brd,
 		sector += copy >> SECTOR_SHIFT;
 		copy = n - copy;
 		page = brd_lookup_page(brd, sector);
-		if (page) {
-			src = kmap_atomic(page);
-			memcpy(dst, src, copy);
-			kunmap_atomic(src);
-		} else
+		if (page)
+			memcpy_from_page(dst, page, offset, copy);
Why 'offset'?
Will fix it in the V1.
Ira
quoted
+		else
 			memset(dst, 0, copy);
 	}
 }
-- 
2.22.1
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help