Re: [PATCH] block: fix bd_size_lock use
From: Jens Axboe <axboe@kernel.dk>
Date: 2021-01-28 14:33:30
On 1/27/21 11:36 PM, Damien Le Moal wrote:
Some block device drivers, e.g. the skd driver, call set_capacity() with
IRQ disabled. This results in lockdep ito complain about inconsistent
lock states ("inconsistent {HARDIRQ-ON-W} -> {IN-HARDIRQ-W} usage")
because set_capacity takes a block device bd_size_lock using the
functions spin_lock() and spin_unlock(). Ensure a consistent locking
state by replacing these calls with spin_lock_irqsave() and
spin_lock_irqrestore(). The same applies to bdev_set_nr_sectors().
With this fix, all lockdep complaints are resolved.Applied, thanks. -- Jens Axboe