Re: [PATCH v4 2/8] nvme: cleanup zone information initialization
flat view
From: Christoph Hellwig <hch@lst.de>
Date: 2021-01-28 09:29:33
Also in:
linux-nvme, linux-scsi
quoted hunk ↗ jump to hunk
int nvme_revalidate_zones(struct nvme_ns *ns) { - struct request_queue *q = ns->queue; - int ret; - - ret = blk_revalidate_disk_zones(ns->disk, NULL); - if (!ret) - blk_queue_max_zone_append_sectors(q, ns->ctrl->max_zone_append); - return ret; + return blk_revalidate_disk_zones(ns->disk, NULL);
We can just kill off nvme_revalidate_zones now and open code it in the caller as the stub is no needed now that blk_queue_is_zoned always return false for the !CONFIG_BLK_DEV_ZONED case. Otherwise this look great, nice cleanup: Reviewed-by: Christoph Hellwig <hch@lst.de>