[PATCH] zram: fix NULL check before some freeing functions is not needed

Subsystems: block layer, the rest, zram compressed ram block device drvier

STALE2051d

3 messages, 3 authors, 2021-01-26 · open the first message on its own page

[PATCH] zram: fix NULL check before some freeing functions is not needed

From: Tian Tao <tiantao6@hisilicon.com>
Date: 2021-01-26 19:54:08

fixed the below warning:
/drivers/block/zram/zram_drv.c:534:2-8: WARNING: NULL check
before some freeing functions is not needed.

Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
---
 drivers/block/zram/zram_drv.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
index e2933cb..92739b9 100644
--- a/drivers/block/zram/zram_drv.c
+++ b/drivers/block/zram/zram_drv.c
@@ -530,8 +530,7 @@ static ssize_t backing_dev_store(struct device *dev,
 
 	return len;
 out:
-	if (bitmap)
-		kvfree(bitmap);
+	kvfree(bitmap);
 
 	if (bdev)
 		blkdev_put(bdev, FMODE_READ | FMODE_WRITE | FMODE_EXCL);
-- 
2.7.4

Re: [PATCH] zram: fix NULL check before some freeing functions is not needed

From: Minchan Kim <minchan@kernel.org>
Date: 2021-01-25 20:11:20

On Mon, Jan 25, 2021 at 04:13:01PM +0800, Tian Tao wrote:
fixed the below warning:
/drivers/block/zram/zram_drv.c:534:2-8: WARNING: NULL check
before some freeing functions is not needed.

Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
Acked-by: Minchan Kim <minchan@kernel.org>

Thanks.

Re: [PATCH] zram: fix NULL check before some freeing functions is not needed

From: Jens Axboe <axboe@kernel.dk>
Date: 2021-01-26 22:08:48

On 1/25/21 1:13 AM, Tian Tao wrote:
fixed the below warning:
/drivers/block/zram/zram_drv.c:534:2-8: WARNING: NULL check
before some freeing functions is not needed.
Applied, thanks.

-- 
Jens Axboe
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help