Re: [PATCH V2 2/2] block: remove unnecessary argument from blk_execute_rq

From
Guoqing Jiang <hidden>
Date
2021-01-25 04:37:17
Also in
linux-ide, linux-mmc, linux-nfs, linux-nvme, linux-scsi, target-devel, virtualization
Reply to
Ulf Hansson, 2021-01-22

On 1/22/21 10:50, Ulf Hansson wrote:
On Fri, 22 Jan 2021 at 10:28, Guoqing Jiang
[off-list ref] wrote:
quoted
We can remove 'q' from blk_execute_rq as well after the previous change
in blk_execute_rq_nowait.

And more importantly it never really was needed to start with given
that we can trivial derive it from struct request.

Cc: <redacted>
Cc: <redacted>
Cc: <redacted>
Cc: <redacted>
Cc: <redacted>
Cc: <redacted>
Signed-off-by: Guoqing Jiang <redacted>
[...]
quoted
  drivers/mmc/core/block.c          | 10 +++++-----
[...]

 From mmc point of view, please add:

Acked-by: Ulf Hansson <redacted>

At the moment I don't think this will conflict with any changes to
mmc, but if that happens let's sort it then...
Thank you! Will resend and add your acked-by.

Guoqing
Thread (7 messages) 7 messages, 3 authors, last reply 2021-01-25
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help