On Wed, Jan 13, 2021 at 05:07:16AM +0000, Chaitanya Kulkarni wrote:

On 1/11/21 23:35, Christoph Hellwig wrote:

quoted

I can't say I like this helper.  The semantics are a little confusing,
not helped by the name.

Is it because of the name of the helper ? if so can you please suggest a
name.
Because all it has a same code repeated in the three backends and it really
bothers me to see duplicate code, but that just me :P.

Also because it does two rather unrelated things.  Or in other words:
I don't think the helper helps the readability of the code.